[#VISIB-29] If a macro in the body returns HTML, it will be escaped to the browser

Confluence Extension: Visibility Plugin

If a macro in the body returns HTML, it will be escaped to the browser

Created: 16/Nov/07 04:23 AM Updated: 12/Jul/08 11:00 PM

Component/s:

{hide-from}, {hide-if}, {show-if}, {show-to}

Affects Version/s:

1.6.0

Fix Version/s:

1.7.0

Time Tracking:

Not Specified

Issue Links:

Duplicate

This issue is duplicated by:

~~VISIB-39~~ show-to and hide-from do not work with note, info and tip macros

Relates

This issue relates to:

~~VISIB-26~~ {show-to} does not render wiki markup when wrapped around an {include} macro

Description

« Hide

Eg:

{show-if:display=default}{toc}{show-if}

There is no easy fix for this, since it's basically due to a bug in Confluence - it doesn't correctly handle rendering returned wiki markup.

There are two possible workarounds:

1. Prerender everything in the visibility macros. Downside is that it will break backwards compatibility - it was designed to basically be invisible - you could use it to turn on list items, table rows etc. Prerendering will break that completely.
2. Prerender on request. Basically, add a parameter which will prerender the content if something wacky happens. It will potentially break some of the layout, but that's the price at the moment...

Option 2 is really the only realistic one, unfortunately...none are ideal.

All

Comments

Work Log

Change History

Sort Order:

[ Permalink | « Hide ]

Bob Swift added a comment - 27/Nov/07 08:38 PM - edited

Not sure if this is the same problem, but the following use to render properly using 1.5 but not on 1.6. I just reverted back to 1.5.

{show-to:space=Systems}
{color:#ff6666} new!{color}
{show-to}

[ Permalink | « Hide ]

Jeff Heinen added a comment - 06/Dec/07 12:13 AM

Is there a open issue for the confluence bug? That way we can go vote on that issue as well.

[ Permalink | « Hide ]

David Peterson added a comment - 17/Dec/07 02:03 AM

I'll be looking at getting this back into somewhat-working order ASAP. In the meantime, the Confluence bug report for the core problem is here:

http://jira.atlassian.com/browse/CONF-3995

Please vote/comment/harass Atlassian to your heart's content...that issue has been open for quite some time now...

[ Permalink | « Hide ]

Simon Wheatley added a comment - 19/Dec/07 05:41 PM

Just hit this issue... very irritating. You can get around it by defining a User Macro containing your desired wiki markup, then using the User Macro inside the show-to or whatever; but this won't be convenient in all cases.

I'm off to vote on the Atlassian bug.

[ Permalink | « Hide ]

Guy Fraser added a comment - 20/Dec/07 04:10 PM

Adaptavist have experienced this bug on a number of other sites - I also voted/commented/watched the CONF-3995 issue.

To solve the problem, however, we found that downgrading to the previous release of the Visibility plugin solved the issue

[ Permalink | « Hide ]

Volker Kleinschmidt added a comment - 21/Mar/08 06:41 AM - edited

Yes, show-to 1.5 works fine (we're still on Conf 2.5) to contain things like {info} macros - so what's changed so much between 1.5 and 1.6 that suddenly this Conf-3995 has become such a horrible issue for you?

[ Permalink | « Hide ]

David Peterson added a comment - 22/Mar/08 02:19 PM

Since it was the lesser of two evils the solution has basically been to revert to the original code for 1.5. This means that {include} will not correctly render Unable to render embedded object: File (image.jpg) not found. or other macro markup, but at this point I'm basically writing this off as a bug in {include}. There is a workaround - use {report-info:content:body|render=wiki|source=Page To Include} instead. This will work as expected.