[#LINK-85] Use of 'link-window' plugin results in JavaScript error in IE7 (and at least on one other browser --- Avant)

Confluence Extension: Linking Plugin

Use of 'link-window' plugin results in JavaScript error in IE7 (and at least on one other browser --- Avant)

Created: 20/Jun/07 08:37 PM Updated: 11/Jul/07 09:31 AM

Component/s:

None

Affects Version/s:

2.3.2

Fix Version/s:

2.4

Time Tracking:

Original Estimate:

1 hour

Remaining Estimate:

1 hour

Time Spent:

Not Specified

Environment:

Internet Explorer 7 or Avant Browser 11.0.46

Issue Links:

Duplicate

This issue is duplicated by:

~~LINK-81~~ Use of 'link-window' plugin results in JavaScript error in IE7 (and at least on one other browser --- Avant)

Description

« Hide

Possibly owing to a missing equal sign in a JavaScript parameter, the link-window macro results in a script error on browsers rendered by the Internet Explorer engine.

Example:

<a href='http://my.sensorlogic.com/slflex/app/std' target='_blank' onclick='if (!window.focus) return true;
window.open(this.href.location, "1181069884213", width=null,height=null,scrollbars=yes,toolbar=yes,
location=yes,statusbar=yes,menubar=yes,resizableyes');return false;' onkeypress='return this.click()' 
title='Visit location in new window'>log in<sup><img width='12' height='12' border='0' align='absmiddle' 
src='/confluence/download/resources/net.customware.confluence.plugin.linking:link-to/img/newwindow.png' 
class='rendericon' alt=''/></sup></a> to the blah blah blah....

Notice the final parameter of the window.open function:
resizableyes

Firefox ignores the error

All

Comments

Work Log

Change History

Sort Order:

[ Permalink | « Hide ]

David Peterson added a comment - 11/Jul/07 09:31 AM

Fixed. For the record, the parameter was incorrect, but the more significant problem was that I was using single quotes inside a single-quoted attribute, so the javascript was being truncated. Switching the internal quote to double quotes solved the problem.