[#LINK-118] Emit CSS classes for any emitted HTML - Adaptavist Public Issue Tracker

Confluence Extension: Linking Plugin

Emit CSS classes for any emitted HTML

Created: 23/Jun/08 03:33 AM Updated: 28/Oct/08 12:02 PM

Component/s:

{add-page}

Affects Version/s:

None

Fix Version/s:

2.6.5

Time Tracking:

Not Specified

Description

« Hide

In the add-page-form macro, the submit button ends up jammed against the text input for the new page name. Page designers could fix this if the emitted HTML contained some CSS classes. I always hate it when issue submitters tell me something is easy, but I've inspected the source and I'm inclined to call this ... well, fairly easy.

And if I may get on a soapbox for a moment, it just ain't right to emit unstylable HTML – literally slams the door on the fingers of page designers.

All

Comments

Work Log

Change History

Sort Order:

[ Permalink | « Hide ]

David Peterson added a comment - 23/Jun/08 03:55 AM

Yeah, should be easy enough to add to the next version. In the meantime, you could use the {span} macro from Adaptavist's Content Formatting plugin to wrap a 'classed' element around it and style it from there. Possibly hard to differentiate the two <input>elements though...

[ Permalink | « Hide ]

Steve Lane added a comment - 23/Jun/08 04:09 AM

Nice suggestion, I'll try it. I'm using Adaptavist Theme Builder, so I added some custom CSS that worked OK. Forgive the remarks on door-slamming – seems many macros happily emit raw HTML – like the jira issues macro, go figure.

[ Permalink | « Hide ]

David Peterson added a comment - 23/Jun/08 04:17 AM

No problems. I actually agree completely. I particularly hate it when macros output hard-coded titles or other text... add-page-form was a pretty quick-n-dirty addition that was added for a specific client requirement, so it hasn't really gotten the TLC it probably deserves...

[ Permalink | « Hide ]

Bo Wang [CustomWare] added a comment - 28/Oct/08 04:59 AM

Hi Steve,

Ive added a class parameter to the macro, the specified class will be added to the input text field and the submit button, for example: {add-page-form:class=myClass}Add page{add-page-form} will add myClass as the class for the 2 input fields, I will update he documentation to reflect this addition shortly.

Regards,
Bo

[ Permalink | « Hide ]

Steve Lane added a comment - 28/Oct/08 12:02 PM

Very nice, thanks! I'll look for it.